Modify checkstyle to be a required item. (#948)

dlink-client/dlink-client-1.14/src/main/java/com/dlink/utils/FlinkStreamProgramWithoutPhysical.java

@@ -39,16 +39,16 @@ import org.apache.flink.table.planner.plan.rules.FlinkStreamRuleSets;
  * @since 2022/8/20 23:33
  */
 public class FlinkStreamProgramWithoutPhysical {
-    private final static String SUBQUERY_REWRITE = "subquery_rewrite";
-    private final static String TEMPORAL_JOIN_REWRITE = "temporal_join_rewrite";
-    private final static String DECORRELATE = "decorrelate";
-    private final static String DEFAULT_REWRITE = "default_rewrite";
-    private final static String PREDICATE_PUSHDOWN = "predicate_pushdown";
-    private final static String JOIN_REORDER = "join_reorder";
-    private final static String PROJECT_REWRITE = "project_rewrite";
-    private final static String LOGICAL = "logical";
-    private final static String LOGICAL_REWRITE = "logical_rewrite";
-    private final static String TIME_INDICATOR = "time_indicator";
+    private static final String SUBQUERY_REWRITE = "subquery_rewrite";
+    private static final String TEMPORAL_JOIN_REWRITE = "temporal_join_rewrite";
+    private static final String DECORRELATE = "decorrelate";
+    private static final String DEFAULT_REWRITE = "default_rewrite";
+    private static final String PREDICATE_PUSHDOWN = "predicate_pushdown";
+    private static final String JOIN_REORDER = "join_reorder";
+    private static final String PROJECT_REWRITE = "project_rewrite";
+    private static final String LOGICAL = "logical";
+    private static final String LOGICAL_REWRITE = "logical_rewrite";
+    private static final String TIME_INDICATOR = "time_indicator";
 
     public static FlinkChainedProgram buildProgram(Configuration config) {
         FlinkChainedProgram chainedProgram = new FlinkChainedProgram();

dlink-common/src/main/java/com/dlink/utils/JSONUtil.java

@@ -26,7 +26,6 @@ import static com.fasterxml.jackson.databind.DeserializationFeature.FAIL_ON_UNKN
 import static com.fasterxml.jackson.databind.DeserializationFeature.READ_UNKNOWN_ENUM_VALUES_AS_NULL;
 import static com.fasterxml.jackson.databind.MapperFeature.REQUIRE_SETTERS_FOR_GETTERS;
 
-import com.dlink.assertion.Asserts;
 
 import java.io.IOException;
 import java.util.ArrayList;
@@ -51,6 +50,8 @@ import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.fasterxml.jackson.databind.node.TextNode;
 import com.fasterxml.jackson.databind.type.CollectionType;
 
+import com.dlink.assertion.Asserts;
+
 /**
  * JSONUtil
  *

dlink-core/src/main/java/com/dlink/explainer/Explainer.java

@@ -19,14 +19,6 @@
 
 package com.dlink.explainer;
 
-import org.apache.flink.runtime.rest.messages.JobPlanInfo;
-import org.apache.flink.table.catalog.CatalogManager;
-
-import java.time.LocalDateTime;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Map;
-
 import com.dlink.assertion.Asserts;
 import com.dlink.constant.FlinkSQLConstant;
 import com.dlink.executor.Executor;
@@ -52,6 +44,15 @@ import com.dlink.trans.Operations;
 import com.dlink.utils.FlinkUtil;
 import com.dlink.utils.LogUtil;
 import com.dlink.utils.SqlUtil;
+
+import org.apache.flink.runtime.rest.messages.JobPlanInfo;
+import org.apache.flink.table.catalog.CatalogManager;
+
+import java.time.LocalDateTime;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
 

dlink-core/src/main/java/com/dlink/plus/FlinkSqlPlus.java

@@ -116,7 +116,7 @@ public class FlinkSqlPlus {
         return explainer.getJobPlanInfo(statement);
     }
 
-    public List<LineageRel> getLineage(String statement){
+    public List<LineageRel> getLineage(String statement) {
         return explainer.getLineage(statement);
     }
 }

dlink-executor/src/main/java/com/dlink/executor/Executor.java

@@ -46,8 +46,6 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
-import com.dlink.utils.LineageContext;
-import com.dlink.utils.SqlUtil;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
@@ -381,7 +379,7 @@ public abstract class Executor {
         return stEnvironment.parseAndLoadConfiguration(statement, environment, setConfig);
     }
 
-    public List<LineageRel> getLineage(String statement){
+    public List<LineageRel> getLineage(String statement) {
         return stEnvironment.getLineage(statement);
     }
 }

pom.xml

@@ -480,7 +480,7 @@
                         <consoleOutput>true</consoleOutput>
                         <encoding>UTF-8</encoding>
                         <configLocation>style/checkstyle.xml</configLocation>
-                        <failOnViolation>false</failOnViolation>
+                        <failOnViolation>true</failOnViolation>
                         <violationSeverity>warning</violationSeverity>
                         <includeTestSourceDirectory>true</includeTestSourceDirectory>
                         <sourceDirectories>
@@ -488,14 +488,14 @@
                         </sourceDirectories>
                         <excludes>**\/generated-sources\/</excludes>
                     </configuration>
-<!--                    <executions>-->
-<!--                        <execution>-->
-<!--                            <phase>compile</phase>-->
-<!--                            <goals>-->
-<!--                                <goal>check</goal>-->
-<!--                            </goals>-->
-<!--                        </execution>-->
-<!--                    </executions>-->
+                    <executions>
+                        <execution>
+                            <phase>compile</phase>
+                            <goals>
+                                <goal>check</goal>
+                            </goals>
+                        </execution>
+                    </executions>
                 </plugin>
             </plugins>
         </pluginManagement>
@@ -513,11 +513,6 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
             </plugin>
-
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-jar-plugin</artifactId>
-            </plugin>
         </plugins>
     </build>
 </project>